Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate githubToken in favour of githubAuthToken #184

Merged
merged 5 commits into from
Apr 23, 2020

Conversation

alejandrohdezma
Copy link
Owner

The githubToken setting has been deprecated in favour of githubAuthToken.

This will probably mean nothing for most of the users, if the default configuration is being used (using a GITHUB_TOKEN environment variable), since the same default configuration is being used for githubAuthToken as was used for githubToken.

The only noticeable change is the type. githubToken had type Token while githubAuthToken has type Option[AuthToken] which allows for directly recover environment variable...

githubAuthToken := sys.env("GITHUB_TOKEN").map(AuthToken)

...while also provides a better integration with other projects, such as sbt-microsites

@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #184 into master will decrease coverage by 0.99%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   87.35%   86.36%   -1.00%     
==========================================
  Files          21       21              
  Lines         174      176       +2     
==========================================
  Hits          152      152              
- Misses         22       24       +2     
Impacted Files Coverage Δ
...m/alejandrohdezma/sbt/github/SbtGithubPlugin.scala 0.00% <0.00%> (ø)
...ejandrohdezma/sbt/github/http/Authentication.scala 66.66% <0.00%> (-33.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83418ca...6f03f26. Read the comment docs.

@alejandrohdezma alejandrohdezma merged commit 61bcb1c into master Apr 23, 2020
@alejandrohdezma alejandrohdezma deleted the feature/deprecate-githubToken branch April 23, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant