Merge pull request #568 from aleju/fix_randomness

Fix randomness of children in .weather
aleju · Jan 14, 2020 · ed87741 · ed87741
2 parents 8424af1 + 202dbc5
commit ed87741
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/changelogs/master/fixed/20200113_fixed_weather_randomness.md b/changelogs/master/fixed/20200113_fixed_weather_randomness.md
@@ -0,0 +1,2 @@
+* Fixed some augmenters in module `weather` not transferring seed values
+  or random states that were provided upon creation to child augmenters. #568
diff --git a/imgaug/augmenters/weather.py b/imgaug/augmenters/weather.py
@@ -528,7 +528,6 @@ class Clouds(meta.SomeOf):
     """
 
     def __init__(self, seed=None, name=None, **old_kwargs):
-        # FIXME random state not transferred to children
         layers = [
             CloudLayer(
                 intensity_mean=(196, 255),
@@ -539,7 +538,9 @@ def __init__(self, seed=None, name=None, **old_kwargs):
                 alpha_size_px_max=(2, 8),
                 alpha_freq_exponent=(-2.5, -2.0),
                 sparsity=(0.8, 1.0),
-                density_multiplier=(0.5, 1.0)
+                density_multiplier=(0.5, 1.0),
+                seed=seed,
+                **old_kwargs
             ),
             CloudLayer(
                 intensity_mean=(196, 255),
@@ -550,7 +551,9 @@ def __init__(self, seed=None, name=None, **old_kwargs):
                 alpha_size_px_max=(64, 128),
                 alpha_freq_exponent=(-2.0, -1.0),
                 sparsity=(1.0, 1.4),
-                density_multiplier=(0.8, 1.5)
+                density_multiplier=(0.8, 1.5),
+                seed=seed,
+                **old_kwargs
             )
         ]
 
@@ -1130,15 +1133,16 @@ def __init__(self, density=(0.005, 0.075), density_uniformity=(0.3, 0.9),
                  flake_size=(0.2, 0.7), flake_size_uniformity=(0.4, 0.8),
                  angle=(-30, 30), speed=(0.007, 0.03),
                  seed=None, name=None, **old_kwargs):
-        # FIXME random state not transferred to children
         layer = SnowflakesLayer(
             density=density,
             density_uniformity=density_uniformity,
             flake_size=flake_size,
             flake_size_uniformity=flake_size_uniformity,
             angle=angle,
             speed=speed,
-            blur_sigma_fraction=(0.0001, 0.001)
+            blur_sigma_fraction=(0.0001, 0.001),
+            seed=seed,
+            **old_kwargs
         )
 
         super(Snowflakes, self).__init__(
@@ -1323,15 +1327,16 @@ def __init__(self, nb_iterations=(1, 3),
                  drop_size=(0.01, 0.02),
                  speed=(0.04, 0.20),
                  seed=None, name=None, **old_kwargs):
-        # FIXME random state not transferred to children
         layer = RainLayer(
             density=(0.03, 0.14),
             density_uniformity=(0.8, 1.0),
             drop_size=drop_size,
             drop_size_uniformity=(0.2, 0.5),
             angle=(-15, 15),
             speed=speed,
-            blur_sigma_fraction=(0.001, 0.001)
+            blur_sigma_fraction=(0.001, 0.001),
+            seed=seed,
+            **old_kwargs
         )
 
         super(Rain, self).__init__(