Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve batchwise augmentation backend #566

Merged
merged 1 commit into from Jan 12, 2020
Merged

Conversation

aleju
Copy link
Owner

@aleju aleju commented Jan 12, 2020

This patch is a follow-up to #451. It makes the original patch no longer breaking, improves naming of methods and adds some tests.
List of changes:

  • Rename augment_batch() to augment_batch_().
  • Rename _augment_batch() to _augment_batch_().
  • Re-add augment_batch() and mark it as deprecated.
  • Add UnnormalizedBatch.fill_from_normalized_batch_() and use it in augment_batch_().
  • Add context testutils.TemporaryDirectory.
  • Add a few tests for augment_batch_().
  • Add tests for augmenting images loaded via functions from popular libraries.

@codecov-io
Copy link

codecov-io commented Jan 12, 2020

Codecov Report

Merging #566 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
+ Coverage   96.45%   96.49%   +0.05%     
==========================================
  Files          40       40              
  Lines       14516    14537      +21     
==========================================
+ Hits        14000    14027      +27     
+ Misses        516      510       -6

This patch is a follow-up to 2d3fdb7
It makes the original patch no longer breaking,
improves naming of methods and adds some tests.
List of changes:

* Rename augment_batch() to augment_batch_().
* Rename _augment_batch() to _augment_batch_().
* Re-add augment_batch() and mark it as deprecated.
* Add UnnormalizedBatch.fill_from_normalized_batch_()
  and use it in augment_batch_().
* Add context testutils.TemporaryDirectory.
* Add a few tests for augment_batch_().
* Add tests for augmenting images loaded via
  functions from popular libraries.
@aleju aleju merged commit cbc6a88 into master Jan 12, 2020
@aleju aleju deleted the finetune_augment_batch branch January 12, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants