Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix randomness of children in .weather #568

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Fix randomness of children in .weather #568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/master/fixed/20200113_fixed_weather_randomness.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
* Fixed some augmenters in module `weather` not transferring seed values
or random states that were provided upon creation to child augmenters. #568
19 changes: 12 additions & 7 deletions imgaug/augmenters/weather.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,6 @@ class Clouds(meta.SomeOf):
"""

def __init__(self, seed=None, name=None, **old_kwargs):
# FIXME random state not transferred to children
layers = [
CloudLayer(
intensity_mean=(196, 255),
Expand All @@ -539,7 +538,9 @@ def __init__(self, seed=None, name=None, **old_kwargs):
alpha_size_px_max=(2, 8),
alpha_freq_exponent=(-2.5, -2.0),
sparsity=(0.8, 1.0),
density_multiplier=(0.5, 1.0)
density_multiplier=(0.5, 1.0),
seed=seed,
**old_kwargs
),
CloudLayer(
intensity_mean=(196, 255),
Expand All @@ -550,7 +551,9 @@ def __init__(self, seed=None, name=None, **old_kwargs):
alpha_size_px_max=(64, 128),
alpha_freq_exponent=(-2.0, -1.0),
sparsity=(1.0, 1.4),
density_multiplier=(0.8, 1.5)
density_multiplier=(0.8, 1.5),
seed=seed,
**old_kwargs
)
]

Expand Down Expand Up @@ -1130,15 +1133,16 @@ def __init__(self, density=(0.005, 0.075), density_uniformity=(0.3, 0.9),
flake_size=(0.2, 0.7), flake_size_uniformity=(0.4, 0.8),
angle=(-30, 30), speed=(0.007, 0.03),
seed=None, name=None, **old_kwargs):
# FIXME random state not transferred to children
layer = SnowflakesLayer(
density=density,
density_uniformity=density_uniformity,
flake_size=flake_size,
flake_size_uniformity=flake_size_uniformity,
angle=angle,
speed=speed,
blur_sigma_fraction=(0.0001, 0.001)
blur_sigma_fraction=(0.0001, 0.001),
seed=seed,
**old_kwargs
)

super(Snowflakes, self).__init__(
Expand Down Expand Up @@ -1323,15 +1327,16 @@ def __init__(self, nb_iterations=(1, 3),
drop_size=(0.01, 0.02),
speed=(0.04, 0.20),
seed=None, name=None, **old_kwargs):
# FIXME random state not transferred to children
layer = RainLayer(
density=(0.03, 0.14),
density_uniformity=(0.8, 1.0),
drop_size=drop_size,
drop_size_uniformity=(0.2, 0.5),
angle=(-15, 15),
speed=speed,
blur_sigma_fraction=(0.001, 0.001)
blur_sigma_fraction=(0.001, 0.001),
seed=seed,
**old_kwargs
)

super(Rain, self).__init__(
Expand Down