Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change **old_kwargs magic to explicit parameters #595

Merged
merged 3 commits into from
Jan 25, 2020
Merged

Change **old_kwargs magic to explicit parameters #595

merged 3 commits into from
Jan 25, 2020

Commits on Jan 25, 2020

  1. Change **old_kwargs magic to explicit parameters 

    The parameter names of class `Augmenter` were recently changed
and the old names were caught by `**old_kwargs`. This was
convenient, but is changed in this patch to be explicitly
`random_state="deprecated", deterministic="deprecated"`.
That is because the `**old_kwargs` magic has the disadvantage
of not necessarily being fully understood by IDEs. These then
cannot detect (and warn) about invalid parameters anymore.
Without the magic parameter they can warn about these,
hence it is the preferred choice here.
    @aleju
    aleju committed Jan 25, 2020
    Configuration menu
    Copy the full SHA
    2297bc6 View commit details
    Browse the repository at this point in the history

  2. Update changelog

    @aleju
    aleju committed Jan 25, 2020
    Configuration menu
    Copy the full SHA
    77dd708 View commit details
    Browse the repository at this point in the history

  3. Fix PR id in changelog

    @aleju
    aleju committed Jan 25, 2020
    Configuration menu
    Copy the full SHA
    5af3fe9 View commit details
    Browse the repository at this point in the history