Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow safe ^2.0 #6

Merged
merged 4 commits into from
Mar 29, 2023
Merged

allow safe ^2.0 #6

merged 4 commits into from
Mar 29, 2023

Conversation

lemorragia
Copy link
Contributor

homogeneity in the require loop "solido/php-coding-standards" -> "solido/phpstan-rules" -> "kcs/class-finder" -> "solido/php-coding-standards"

@alekitto
Copy link
Owner

Please also update composer.lock file

@lemorragia
Copy link
Contributor Author

Please also update composer.lock file

done!

@alekitto
Copy link
Owner

Could you check the tests failures?
It seems that the new version of safe removed the uasort function...

@lemorragia
Copy link
Contributor Author

will do

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #6 (6a892dc) into master (f74bfb2) will decrease coverage by 0.11%.
The diff coverage is 75.00%.

❗ Current head 6a892dc differs from pull request most recent head b2effe4. Consider uploading reports for the commit b2effe4 to get more accurate results

@@             Coverage Diff              @@
##             master       #6      +/-   ##
============================================
- Coverage     90.13%   90.02%   -0.11%     
- Complexity      309      311       +2     
============================================
  Files            34       34              
  Lines           669      672       +3     
============================================
+ Hits            603      605       +2     
- Misses           66       67       +1     
Impacted Files Coverage Δ
lib/Iterator/PhpDocumentorIterator.php 81.51% <75.00%> (-0.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alekitto alekitto merged commit 0727196 into alekitto:master Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants