fix metadata requests version 1

Handle topic array length when it's -1 And adds some fields to the metadata response closes travisjeffery#159
alekitto · Jun 26, 2020 · 47faa69 · 47faa69
1 parent b1b65b4
commit 47faa69
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/protocol/decoder.go b/protocol/decoder.go
@@ -263,10 +263,10 @@ func (d *ByteDecoder) StringArray() ([]string, error) {
 		d.off = len(d.b)
 		return nil, ErrInsufficientData
 	}
-	n := int(Encoding.Uint32(d.b[d.off:]))
+	n := int32(Encoding.Uint32(d.b[d.off:]))
 	d.off += 4
 
-	if n == 0 {
+	if n == 0 || n == -1 {
 		return nil, nil
 	}
 

diff --git a/protocol/metadata_response.go b/protocol/metadata_response.go
@@ -39,6 +39,7 @@ func (r *MetadataResponse) Encode(e PacketEncoder) (err error) {
 			return err
 		}
 		e.PutInt32(b.Port)
+		e.PutString("")
 	}
 	if r.APIVersion >= 1 {
 		e.PutInt32(r.ControllerID)
@@ -51,6 +52,7 @@ func (r *MetadataResponse) Encode(e PacketEncoder) (err error) {
 		if err = e.PutString(t.Topic); err != nil {
 			return err
 		}
+		e.PutInt8(0)
 		if err = e.PutArrayLength(len(t.PartitionMetadata)); err != nil {
 			return err
 		}