Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for highflow usb #90

Merged
merged 4 commits into from
Sep 3, 2023
Merged

Add support for highflow usb #90

merged 4 commits into from
Sep 3, 2023

Conversation

leoratte
Copy link
Contributor

Checklist:

  • My code follows Linux code style guidelines
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have tested my changes on the affected device(s) - tested on highflow usb

@leoratte
Check if temp sensors of legacy devices are connected
22a3d4e 
Signed-off-by: Leonard Anderweit <leonard.anderweit@gmail.com>
@leoratte
Makefile: Checkpatch docs
064a061 
Signed-off-by: Leonard Anderweit <leonard.anderweit@gmail.com>
@leoratte leoratte mentioned this pull request Aug 31, 2023
Closed
aleksamagicka
aleksamagicka requested changes Sep 1, 2023
View reviewed changes
Copy link
Owner

@aleksamagicka aleksamagicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! A few comments enclosed.

aquacomputer_d5next.c Outdated Show resolved Hide resolved
aquacomputer_d5next.c Outdated Show resolved Hide resolved
aquacomputer_d5next.c Show resolved Hide resolved
@leoratte leoratte marked this pull request as ready for review September 1, 2023 18:40
@leoratte
Add Aquacomputer High Flow USB
220cc0b 
Support for 2 temperature sensors, firmware version and serial number.

Signed-off-by: Leonard Anderweit <leonard.anderweit@gmail.com>
@leoratte
highflow: Add flow meter
391f2a2 
Signed-off-by: Leonard Anderweit <leonard.anderweit@gmail.com>
@leoratte
Copy link
Contributor Author

leoratte commented Sep 1, 2023

Addressed your comments and added reading firmware version and serial number which were missing.

@aleksamagicka aleksamagicka merged commit 8363824 into aleksamagicka:main Sep 3, 2023
3 checks passed
@leoratte leoratte deleted the wip-highflow branch September 4, 2023 16:50
@aleksamagicka
Copy link
Owner

I've just found that LibreHardwareMonitor has MPS support implemented (#89), and all offsets look exactly the same, including the product ID. Seems like we have both covered now.

aleksamagicka added a commit that referenced this pull request Sep 24, 2023
@aleksamagicka
hwmon: (aquacomputer_d5next) Add support for Aquacomputer High Flow U…
cf54244 
…SB and MPS Flow

Extend aquacomputer_d5next driver to expose various hardware sensors of the
Aquacomputer High Flow USB flow sensor, which communicates through a
proprietary USB HID protocol. This commit also adds support for the sensors
of the MPS Flow devices, as they have the same USB product ID and sensor
layouts. Implemented by Leonard Anderweit [1].

Internal and and external temp sensor readings are available, along with
the flow sensor.

Additionally, serial number and firmware version are exposed through
debugfs.

[1] #90

Originally-from: Leonard Anderweit <leonard.anderweit@gmail.com>
Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
aleksamagicka added a commit that referenced this pull request Sep 27, 2023
@aleksamagicka
hwmon: (aquacomputer_d5next) Add support for Aquacomputer High Flow U…
f762984 
…SB and MPS Flow

Extend aquacomputer_d5next driver to expose various hardware sensors of the
Aquacomputer High Flow USB flow sensor, which communicates through a
proprietary USB HID protocol. This commit also adds support for the sensors
of the MPS Flow devices, as they have the same USB product ID and sensor
layouts. Implemented by Leonard Anderweit [1].

Internal and and external temp sensor readings are available, along with
the flow sensor.

Additionally, serial number and firmware version are exposed through
debugfs.

[1] #90

Originally-from: Leonard Anderweit <leonard.anderweit@gmail.com>
Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this pull request Oct 17, 2023
@aleksamagicka @intel-lab-lkp
hwmon: (aquacomputer_d5next) Add support for Aquacomputer High Flow U…
cce3850 
…SB and MPS Flow

Extend aquacomputer_d5next driver to expose various hardware sensors of the
Aquacomputer High Flow USB flow sensor, which communicates through a
proprietary USB HID protocol. This commit also adds support for the sensors
of the MPS Flow devices, as they have the same USB product ID and sensor
layouts. Implemented by Leonard Anderweit [1].

Internal and external temp sensor readings are available, along with
the flow sensor.

Additionally, serial number and firmware version are exposed through
debugfs.

[1] aleksamagicka/aquacomputer_d5next-hwmon#90

Originally-from: Leonard Anderweit <leonard.anderweit@gmail.com>
Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
aleksamagicka added a commit that referenced this pull request Oct 29, 2023
@aleksamagicka
hwmon: (aquacomputer_d5next) Add support for Aquacomputer High Flow U…
9446ba0 
…SB and MPS Flow

Extend aquacomputer_d5next driver to expose various hardware sensors of the
Aquacomputer High Flow USB flow sensor, which communicates through a
proprietary USB HID protocol. This commit also adds support for the sensors
of the MPS Flow devices, as they have the same USB product ID and sensor
layouts. Implemented by Leonard Anderweit [1].

Internal and and external temp sensor readings are available, along with
the flow sensor.

Additionally, serial number and firmware version are exposed through
debugfs.

[1] #90

Originally-from: Leonard Anderweit <leonard.anderweit@gmail.com>
Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
roxell pushed a commit to roxell/linux that referenced this pull request Oct 30, 2023
@aleksamagicka @groeck
hwmon: (aquacomputer_d5next) Add support for Aquacomputer High Flow U…
a91c4af 
…SB and MPS Flow

Extend aquacomputer_d5next driver to expose various hardware sensors of the
Aquacomputer High Flow USB flow sensor, which communicates through a
proprietary USB HID protocol. This commit also adds support for the sensors
of the MPS Flow devices, as they have the same USB product ID and sensor
layouts. Implemented by Leonard Anderweit [1].

Internal and external temp sensor readings are available, along with
the flow sensor.

Additionally, serial number and firmware version are exposed through
debugfs.

[1] aleksamagicka/aquacomputer_d5next-hwmon#90

Originally-from: Leonard Anderweit <leonard.anderweit@gmail.com>
Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
Link: https://lore.kernel.org/r/20231016083559.139341-3-savicaleksa83@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
roxell pushed a commit to roxell/linux that referenced this pull request Oct 31, 2023
@aleksamagicka @groeck
hwmon: (aquacomputer_d5next) Add support for Aquacomputer High Flow U…
ceaa224 
…SB and MPS Flow

Extend aquacomputer_d5next driver to expose various hardware sensors of the
Aquacomputer High Flow USB flow sensor, which communicates through a
proprietary USB HID protocol. This commit also adds support for the sensors
of the MPS Flow devices, as they have the same USB product ID and sensor
layouts. Implemented by Leonard Anderweit [1].

Internal and external temp sensor readings are available, along with
the flow sensor.

Additionally, serial number and firmware version are exposed through
debugfs.

[1] aleksamagicka/aquacomputer_d5next-hwmon#90

Originally-from: Leonard Anderweit <leonard.anderweit@gmail.com>
Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
Link: https://lore.kernel.org/r/20231016083559.139341-3-savicaleksa83@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksamagicka aleksamagicka aleksamagicka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leoratte @aleksamagicka