-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thank you for updating this repo and a few questions! #24
Comments
Hello there! Thank you for your first contribution! :) To answer your questions:
|
When I think of it I would like to have my dev-containers build automatically and pushed to docker hub so I will do that with #27 |
Hi again. I have now implemented the things I mentioned. If you'd like, you can find the process in the issues linked above. Please do let me know if you have any questions, concerns or better ways to document the project. Thank you! :) |
Closing this issue for now due to inactivity. Please let me know if you have any further questions or comments |
Hi there!
I'm fairly new to docker and have been messing around with the original repo of this container, and found yours which updates pihole and unbound. Thank you so much for these updates!
I have a few contributions that I'll make later on to this repo such as some documentation/variable additions due to Apple Privacy, etc.
A few questions:
Where are you setting the version for pihole in this? I see the older version in the VERSION file, but see a newer version in the pihole UI.
I'm able to successfully get your container working which is awesome, but how did you build and push this to docker hub? When I tried to create a custom version using the docker file and ran the build_and_push.sh I got the following error when trying to run the container:
[i] pihole-FTL (no-daemon) will be started as pihole
s6-rc: info: service _startup successfully started
s6-rc: info: service pihole-FTL: starting
s6-rc: info: service pihole-FTL successfully started
s6-rc: info: service lighttpd: starting
s6-rc: info: service lighttpd successfully started
s6-rc: info: service _postFTL: starting
s6-rc: info: service _postFTL successfully started
s6-rc: info: service legacy-services: starting
Checking if custom gravity.db is set in /etc/pihole/pihole-FTL.conf
services-up: info: copying legacy longrun unbound (no readiness notification)
s6-rc: info: service legacy-services successfully started
ifelse: fatal: unable to exec bash
: No such file or directory
Perhaps I didn't build and push it to docker hub correctly, but I'm not sure how to push it properly.
Thanks again!!
The text was updated successfully, but these errors were encountered: