release-start with commitDevelopmentVersionAtStart uses releaseFinishMessage

[akuntsch]

See https://github.com/aleksandr-m/gitflow-maven-plugin/blob/master/src/main/java/com/amashchenko/maven/plugin/gitflow/GitFlowReleaseStartMojo.java#L210

Shouldn't it use the releaseStartMessage?

[raehalme]

releaseStartMessage is used when committing the release version. The line you're referring to commits the next snapshot version and therefore uses the releaseFinishMessage.

[akuntsch]

I know. But the commit still happens during release-start, so imo it does not make sense to use the releaseFinishMessage when the release is not yet finished.

[raehalme]

The releaseFinishMessage has a value of update for next development version and that's what it does.

[raehalme]

I agree the name of the message is a bit misleading in this context.

[akuntsch]

Yea, I didn't think about the default releaseStartMessage.

[akuntsch]

So how do we proceed? I think there are multiple options:

1. change the default commit messages
2. add another commit message for that special case
3. leave as is

Maybe we can get @aleksandr-m's opinion on this?

[aleksandr-m]

What exactly the problem is? Are you overriding default message? How bad does it looks like with your configuration?

[akuntsch]

Yes, I am overriding the default messages.

For example if I set the releaseStartMessage to release start and the release finish message to release finish when using commitDevelopmentVersionAtStart, then the commit created on the development branch during mvn gitflow:release-start will have release finish as message, which is pretty misleading.