-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-start with commitDevelopmentVersionAtStart uses releaseFinishMessage #120
Comments
releaseStartMessage is used when committing the release version. The line you're referring to commits the next snapshot version and therefore uses the releaseFinishMessage. |
I know. But the commit still happens during release-start, so imo it does not make sense to use the releaseFinishMessage when the release is not yet finished. |
The releaseFinishMessage has a value of |
I agree the name of the message is a bit misleading in this context. |
Yea, I didn't think about the default releaseStartMessage. |
So how do we proceed? I think there are multiple options:
Maybe we can get @aleksandr-m's opinion on this? |
What exactly the problem is? Are you overriding default message? How bad does it looks like with your configuration? |
Yes, I am overriding the default messages. For example if I set the releaseStartMessage to |
See https://github.com/aleksandr-m/gitflow-maven-plugin/blob/master/src/main/java/com/amashchenko/maven/plugin/gitflow/GitFlowReleaseStartMojo.java#L210
Shouldn't it use the releaseStartMessage?
The text was updated successfully, but these errors were encountered: