Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict during release-finish when using commitDevelopmentVersionAtStart & useSnapshotInRelease #122

Closed
philharperv opened this issue Aug 14, 2018 · 3 comments

Comments

@philharperv
Copy link

How to replicate:

Set the following properties

commitDevelopmentVersionAtStart = true
useSnapshotInRelease = true

Run release-start

  • Creates a release branch and increases the version in the development branch.

Run release-finish

  • Removes the SNAPSHOT from the version in the release branch
  • Tags and merges into master
  • Merges into development branch

At this point there is a conflict because there was a commit in the development branch to increase the version and there was a commit in the release branch to remove the SNAPSHOT from the version.

Example Conflict

++<<<<<<< HEAD
 +        <version>0.4.2-SNAPSHOT</version>
++=======
+         <version>0.4.1</version>
++>>>>>>> release/0.4.1

Thanks,

Phil

@philharperv
Copy link
Author

I am not sure what the best fix for this is. But one approach would be to increase the version and add SNAPSHOT after merging the release branch into master but before merging it back into develop.

@philharperv
Copy link
Author

Thanks for merging this in for us. Do you have an idea as to when you will release the latest version to maven repository?

@aleksandr-m
Copy link
Owner

@philharperv 1.11.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants