Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix finish should not necessarly bump to next development version #230

Closed
rostskadat opened this issue Apr 30, 2020 · 0 comments · Fixed by #268
Closed

Hotfix finish should not necessarly bump to next development version #230

rostskadat opened this issue Apr 30, 2020 · 0 comments · Fixed by #268

Comments

@rostskadat
Copy link

Description:

Imagine you have a project with a master branch whose last release is 1.0 and a development branch whose current branch is 1.1-SNAPSHOT. Doing a succession of hotfix-start / hotfix-finish with the successive version 1.0.1, 1.0.2 ...1.0.n will erroneously increment the development snapshot to 1.2-SNAPSHOT, 1.3-SNAPSHOT, etc..

Steps To Reproduce:

1- Start and then finish several hotfix on the TestProject
2- Each time you finish the hotfix the development version is also incremented.

Expected Result:

I would expect the hotfix-finish goal to:
Consider that if the hotfix version is less than the development version then the development should not be bumped to the next development version.

rostskadat pushed a commit to rostskadat/gitflow-maven-plugin that referenced this issue Apr 30, 2020
rostskadat pushed a commit to rostskadat/gitflow-maven-plugin that referenced this issue Apr 30, 2020
rostskadat pushed a commit to rostskadat/gitflow-maven-plugin that referenced this issue Apr 30, 2020
rostskadat pushed a commit to rostskadat/gitflow-maven-plugin that referenced this issue May 1, 2020
…OM commit

After the user has solved the conflicts that appeared during the first
hotfix-finish, it should be possible to restart the hotfix-finish
without failing. The first fix is that if we are tagging (skipTag=false)
we should allow the user to avoid failing. Since the tagging happened on
master before possible merge fail on develop, we would fail when tagging
the second time around. The second failure fix is to make sure that the
development version is not incremented indiscriminately.
There is one last problem, which is not solved yet: the fact that if we
have a conflict when merging on develop, we should backtrack the commit
were we set the version to hotfix branch...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant