Fixes #235 add projectVersionPolicyId parameter to support VersionPolicy implementations #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onPolicy implementations
|
i've added an integration test |
aleksandr-m
reviewed
Jan 7, 2022
src/main/java/com/amashchenko/maven/plugin/gitflow/GitFlowVersionInfo.java
Outdated
Show resolved
Hide resolved
aleksandr-m
reviewed
Jan 7, 2022
src/main/java/com/amashchenko/maven/plugin/gitflow/GitFlowVersionInfo.java
Outdated
Show resolved
Hide resolved
|
Thank you. |
|
great, thanks! |
|
@stefanseifert I believe I've seen some review of the gitflow-maven-plugin written by you. Can you update it to reflect the latest changes? |
|
@aleksandr-m this PR is already merged (and released) - what do you mean? |
|
@stefanseifert I was referring to this how to article. Also, can you think of any other features that are missing right now? |
|
ah, i see. i've completely forgotten about this blog post, it's more a migration guide for users in the wcm.io ecosystem than a review. i've updated it to reflect the current feature set. i'm very happy with the current state of the gitflow plugin and appreciate all the work you've put into it in the last months! |
|
Great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235