-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds parameter "branchName" on the release-start goal #70
Closed
emmanuel-coquelin
wants to merge
2
commits into
aleksandr-m:master
from
emmanuel-coquelin:Issue-65-BranchName
Closed
Adds parameter "branchName" on the release-start goal #70
emmanuel-coquelin
wants to merge
2
commits into
aleksandr-m:master
from
emmanuel-coquelin:Issue-65-BranchName
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to specify the name of the branch to create (prefixed by the releasePrefix)
Is this PR ever going to be merged? I'm likely to have this exact use case soon. |
@manderson23 Which issue exactly? Can you elaborate? |
This PR to add the branch name parameter. It's been open for 2 years
without being merged or rejected. I wondered if it would get merged as it
would help with the workflow I need to follow.
…On Sun, 1 Sep 2019, 21:40 Aleksandr Mashchenko, ***@***.***> wrote:
@manderson23 <https://github.com/manderson23> Which issue exactly? Can
you elaborate?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#70?email_source=notifications&email_token=AAM3JIMEVOOD4T57AAAF4XTQHQSEVA5CNFSM4D4Q64DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5UKG3A#issuecomment-526951276>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAM3JIOP2VPVM5EL7PE74BTQHQSEVANCNFSM4D4Q64DA>
.
|
@manderson23 Can you describe your workflow? Why do you need this? |
Release start creating a long running branch named release/1.0 where 1.0.0
and all subsequent 1.0.x releases would be made. Unlike regular usage the
branch is never merged to master.
…On Sun, 1 Sep 2019, 21:51 Aleksandr Mashchenko, ***@***.***> wrote:
@manderson23 <https://github.com/manderson23> Can you describe your
workflow? Why do you need this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#70?email_source=notifications&email_token=AAM3JIN3PEMJUIQVG2IHRQDQHQTMPA5CNFSM4D4Q64DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5UKMAY#issuecomment-526951939>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAM3JINETEETPLNYX332CXLQHQTMPANCNFSM4D4Q64DA>
.
|
@manderson23 It is a |
I'm pretty sure I investigated support branches and there were issues there
too that meant it didn't quite work. I've got some scripting that meets my
needs so it isn't a must have. Thanks for the feedback though.
…On Sun, 1 Sep 2019, 22:02 Aleksandr Mashchenko, ***@***.***> wrote:
@manderson23 <https://github.com/manderson23> It is a support branch. I
don't think this PR will give you what you want.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#70?email_source=notifications&email_token=AAM3JIMSBF4M5W6HCDZXZDLQHQUYDA5CNFSM4D4Q64DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5UKR4I#issuecomment-526952689>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAM3JILA4WFEQJXHRFO4QADQHQUYDANCNFSM4D4Q64DA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #65 :
Adds a parameter "branchName" on the release-start goal to specify the name of the branch to create (prefixed by the releasePrefix value).
This superseeds the "sameBranchName" parameter.