Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some objects only get oulined in Editor depending on their shader #18

Closed
jcrombez opened this issue Aug 22, 2020 · 4 comments
Closed

Some objects only get oulined in Editor depending on their shader #18

jcrombez opened this issue Aug 22, 2020 · 4 comments

Comments

@jcrombez
Copy link

jcrombez commented Aug 22, 2020

After i updated HDRP (not sure since which update, i'm using 7.4.3) some object are not outlined while playing in build mode.
It depends wich shader (built with Shader Graph) the object outlined is using.

Do you have any idea what a shader could do that would mess with the outline custom pass in build mode ?

@jcrombez jcrombez changed the title Some shader only get ouline in Editor Some object only get ouline in Editor depending on their shader Aug 22, 2020
@jcrombez jcrombez changed the title Some object only get ouline in Editor depending on their shader Some object only get oulined in Editor depending on their shader Aug 22, 2020
@jcrombez jcrombez changed the title Some object only get oulined in Editor depending on their shader Some objects only get oulined in Editor depending on their shader Aug 22, 2020
@alelievr
Copy link
Owner

Not sure why it's happening 🤔 Are you using the selection code in this package or the outline custom pass provided in the documentation?

Also, can you tell me which shader graphs are you using that work/doesn't work in the build?

@jcrombez
Copy link
Author

Are you talking about this ? https://github.com/alelievr/HDRP-Custom-Passes/blob/master/Assets/CustomPasses/Selection/Shaders/02_Selection_Objects.shader (that's what i'm using)

The shader is from a shader graph based in the "Lit Master" node :

image

@alelievr
Copy link
Owner

alelievr commented Oct 2, 2020

Okay, I tried to repro the issue with this setup:

I created this shadergraph trying to match your settings:
image

Created a sphere in the selection scene and applied this shader:
image

And it works correctly in build (release and debug):
image

Did I miss something in my setup?

@jcrombez
Copy link
Author

jcrombez commented Mar 25, 2021

Sorry for not answering you here, this was during the release period of the project, i had to drop this feature and then totally forgot about it.
I guess i'll see next time i need an outline effect if have more success with this :)

Thanks the help anyway !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants