Fixes to make Alembic exported config work for OpenEXR 2.x or Imath 3.x #355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the way it currently was, the exported AlembicConfig.cmake
was fine for if Imath3 is being used, but for building against older
OpenEXR 2.x, would not work properly.
The change: AlembicIlmBase.cmake sets a variable that reveals whether
Imath3 was found or if we fall back to useing OpenEXR 2.x. Then we use
that to alter what the exported Alembic.config.cmake ought to say in
terms of whether to find_dependency(Imath) or find_dependency(IlmBase).
This extra smidge of complexity can be removed when Imath 3.x is the
true minimum. But given that OpenEXR 2.4 is (unwisely, IMHO) the
choice for VFX Platform 2021 and in the current set of DCC versions, I
believe we need to support OpenEXR 2.4 as a first class citizen for
just a little bit longer.
Signed-off-by: Larry Gritz lg@larrygritz.com