Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the TODO test #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove the TODO test #19

wants to merge 1 commit into from

Conversation

aryx
Copy link

@aryx aryx commented Jun 21, 2023

This prevents to use this repository in other repository with automated testing because the tests currently fail.

test plan:
npm test

This prevents to use this repository in other repository with
automated testing because the tests currently fail.

test plan:
npm test
@aryx
Copy link
Author

aryx commented Jun 21, 2023

@alemuller we would like to use your tree-sitter-make in semgrep, so people can write Semgrep rules to find errors
in Makefiles, but those failing tests are annoying for our release process.
Would you mind merging this PR? This would help us a lot.

@aryx
Copy link
Author

aryx commented Jun 21, 2023

This would help semgrep/semgrep#8087

@aryx
Copy link
Author

aryx commented Jun 26, 2023

ping @alemuller

@aryx
Copy link
Author

aryx commented Jun 27, 2023

@alemuller if you don't maintain this repo anymore, I'll fork it, but I'd rather avoid a fork if we can
agree on merging this PR.

@aryx
Copy link
Author

aryx commented Jul 18, 2023

Ok I'll fork your repo then @alemuller . A bit sad. I would have rather avoided it.

aryx added a commit to semgrep/ocaml-tree-sitter-semgrep that referenced this pull request Jul 18, 2023
This is actually a fork of tree-sitter-make because the original
author does not seem responsive. See
alemuller/tree-sitter-make#19

test plan:
./test-lang make
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant