Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --colorized #39

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Conversation

cpascual
Copy link

Hi, thanks for this nice project. It is working perfectly for my needs... except that I missed the support for the --colorized option of pyreverse.

I just added it and thought that you may be interested in adding it too, so here is a PR.

Note: I didn't see any info about how to contribute, so if I missed something or you prefer some other way of proposing changes, just let me know!

Add a `sphinx_pyreverse_colorized` configuration option.
Copy link
Collaborator

@doublethefish doublethefish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you update the docs we can merge this PR in.

NOTE: I have raised an issue with the pylint team for missing docs for --colorized on their end: pylint-dev/pylint#9573

@cpascual
Copy link
Author

Looks good. If you update the docs we can merge this PR in.

Hi @doublethefish, I am not sure I understand. Your docs link points to the README... but that was already updated in my PR ... are there some other docs that I am missing?

@doublethefish
Copy link
Collaborator

Looks good. If you update the docs we can merge this PR in.

Hi @doublethefish, I am not sure I understand. Your docs link points to the README... but that was already updated in my PR ... are there some other docs that I am missing?

Yes, you're right, completely missed it in the file-list 🤦🏻‍♂️. Thanks for being my seeing-eye aid🧑‍🦯 🙈

@doublethefish doublethefish merged commit bde9809 into alendit:master Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants