Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax setuptools dependency #109

Merged
merged 1 commit into from Aug 25, 2023
Merged

Relax setuptools dependency #109

merged 1 commit into from Aug 25, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 23, 2023

Now that setuptools is on version 68.1.2, would it be possible to unpin the dependency? I have also removed listing wheel explicitly. According to the setuptools documentation:

Historically this documentation has unnecessarily listed wheel in the requires list, and many projects still do that. This is not recommended. The backend automatically adds wheel dependency when it is required, and listing it explicitly causes it to be unnecessarily required for source distribution builds. You should only include wheel in requires if you need to explicitly access it during build time (e.g. if your project needs a setup.py script that imports wheel).

@alengwenus alengwenus merged commit 00b45d5 into alengwenus:dev Aug 25, 2023
11 checks passed
@tjni tjni deleted the unpin-setuptools branch August 25, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants