Docker support #249
Draft
Docker support #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase this branch on the latest master ? |
The custom type did not bring any value to the codebase.
AmozPay
force-pushed
the
AmozPay-docker-support
branch
from
d4985c9
to
b916cbe
Compare
AmozPay
force-pushed
the
AmozPay-docker-support
branch
from
ba89f63
to
a7227e9
Compare
hoh
reviewed
Feb 3, 2023
|
|
||
| /usr/sbin/dockerd 2>&1 | tee /log_docker.txt & | ||
|
|
||
| log "INIT 0 DONE2" |
There was a problem hiding this comment.
What about a comment about Dockerd being started ?
| -v "$(pwd)/firecracker:/opt/aleph-vm/firecracker:ro" \ | ||
| --device /dev/kvm \ | ||
| -p 4020:4020 \ | ||
| alephim/vm-supervisor-dev $@ |
There was a problem hiding this comment.
Can we merge this in the main script or make it explicit that this is for Docker ?
|
|
||
| WORKDIR /opt/aleph-vm | ||
|
|
||
| CMD "bash" |
There was a problem hiding this comment.
What differs from the main Dockerfile ?
| @@ -0,0 +1,3 @@ | |||
| #!/bin/sh | |||
| docker image ls | |||
| docker run --rm -p 8080:8080 amozpay/hello_node | |||
| @@ -10,5 +10,7 @@ else | |||
| DOCKER_COMMAND=docker | |||
| fi | |||
|
|
|||
| echo DOCKER_COMMAND=$DOCKER_COMMAND | |||
|
|
|||
| return Path(settings.FAKE_DATA_VOLUME) | ||
| for volume_bind in str(settings.FAKE_DATA_VOLUME).split(","): | ||
| if volume.mount == volume_bind.split(":")[1]: | ||
| return volume_bind.split(":")[0] |
There was a problem hiding this comment.
What is this change for ? Does it require a comment and a specific commit ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.