Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing error messages #13

Open
manonromain opened this issue Nov 15, 2021 · 0 comments
Open

Missing error messages #13

manonromain opened this issue Nov 15, 2021 · 0 comments

Comments

@manonromain
Copy link

Hi there,

Thanks for your work! One thing I find is missing is logging of error. For instance, when adding an entity without an id and putting it in the dataset, no errors occur even though the item was not actually added.

from ftmstore import Dataset, Store
from followthemoney import model

dataset = Dataset(store=Store(), name="test")
event = model.make_entity("Event")
# event.make_id("my_id") # let's say I forgot this line
dataset.put(event)

for elt in dataset.iterate():
    print(elt)

In that case, my dataset will be empty but I get no error or warning messages.

Best,

@pudo pudo transferred this issue from alephdata/followthemoney Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant