client: allow UserAgent to be set #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, rebuild the feature as a |
tmatth
changed the title
tmatth
changed the title
tmatth
force-pushed
the
feature/user-agent-from-env
branch
from
4a79164
to
70e3704
Compare
Codecov Report
@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 84.24% 84.25% +0.01%
==========================================
Files 56 56
Lines 5724 5729 +5
==========================================
+ Hits 4822 4827 +5
Misses 636 636
Partials 266 266
Continue to review full report at Codecov.
|
tmatth
commented
Apr 12, 2022
tmatth
force-pushed
the
feature/user-agent-from-env
branch
from
70e3704
to
78a7d08
Compare
tmatth
force-pushed
the
feature/user-agent-from-env
branch
from
78a7d08
to
76d766e
Compare
Done. |
|
merged, thanks |
|
This issue is being locked automatically because it has been closed for more than 6 months. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's helpful for debugging to be able to override the hardcoded
gortsplibUser-Agent header, as we can have multiple gortsplib-based clients. I'd also be open to making this a config option or a parameter to the Client, but this was the lowest impact change.It also has the advantage that this parameter can be changed by e.g., docker image without rebuilding.