Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript issues #7

Open
adriengibrat opened this issue Nov 11, 2017 · 4 comments
Open

TypeScript issues #7

adriengibrat opened this issue Nov 11, 2017 · 4 comments

Comments

@adriengibrat
Copy link

I use zxing-typescript in a Typescript project with some strict compiler options

{
	"compilerOptions": {
		"noImplicitAny": true,
		"strictNullChecks": true,
		"noUnusedLocals": true,
		"noUnusedParameters": true,
		"allowUnreachableCode": false,
...
}

and I can't compile ;)

Are you open to PR to enforce stricter typescript rules ?

@aleris
Copy link
Owner

aleris commented Nov 12, 2017 via email

@knocte
Copy link

knocte commented Apr 25, 2019

I will probably commit it with the pdf417 code

Curious, did you ever do this?

@aleris
Copy link
Owner

aleris commented Apr 25, 2019

No sorry, there was a lot of development on a fork, where some improvements were mede. Unfortunately no pd417.

@knocte
Copy link

knocte commented Apr 25, 2019

I'm actually more interested in the strict compiler options, not pdf417 :) did those get enabled in that fork?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants