Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: lazy load AlertListFilter and cancel timer before tab change #436

Closed
wants to merge 1 commit into from
Closed

perf: lazy load AlertListFilter and cancel timer before tab change #436

wants to merge 1 commit into from

Conversation

StayYoung2yz
Copy link
Contributor

@StayYoung2yz StayYoung2yz commented Jan 5, 2021 •
edited
Loading

Lazy load AlertListFilter component and cancel timer before tab change.

  • Also lazy load AlertListFilter component
  • Cancel timer before changing tab (setEnv)
  • revert <alert-detail> template in Alerts.vue or check id before AlertDetail created to prevent loading null id item

#426, #431

perf: lazy load AlertListFilter component and cancel timer before cha…
4081c56 
…nging tab

* Also lazy load AlertListFilter component
* Cancel timer before changing tab (setEnv)
* revert `<alert-detail>` template in Alerts.vue or check id before AlertDetail created to prevent loading null id item

#426, #431
@StayYoung2yz StayYoung2yz changed the title perf: lazy load AlertListFilter component and cancel timer before cha… perf: lazy load AlertListFilter and cancel timer before tab change Jan 5, 2021
@satterly satterly mentioned this pull request Jan 5, 2021
Merged
@satterly
Copy link
Member

satterly commented Jan 5, 2021

Thanks for this PR. I won't merge it but I have used it as the basis for two different PRs that were motivated by this one. 👍

@satterly satterly closed this Jan 5, 2021
This was referenced Jan 5, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@StayYoung2yz @satterly