Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use guest scope as default #1344

Closed
wants to merge 2 commits into from
Closed

Use guest scope as default #1344

wants to merge 2 commits into from

Conversation

escoand
Copy link
Contributor

@escoand escoand commented Oct 23, 2020

Currently the default scope of a new user is user.

This is not ideal when using oidc (and maybe also others) as auth because the user gets created with first login attempt. So the user has maybe more rights than desired.

With this change the default scope is changed to guest.

@satterly
Copy link
Member

Why not just set USER_DEFAULT_SCOPES to read instead of read and write?

USER_DEFAULT_SCOPES = ['read']

@satterly
Copy link
Member

satterly commented Oct 24, 2020

Using this PR #1346 you could do ...

USER_ROLES = ['guest']

... which would set this default role for newly logged in users to "guest".

@escoand
Copy link
Contributor Author

escoand commented Oct 25, 2020

Why not just set USER_DEFAULT_SCOPES to read instead of read and write?

USER_DEFAULT_SCOPES = ['read']

I need all three builtin roles. So setting the default user scope to read forces me to create an additional user defined role for r/w. But I'm also fine with your PR.

@satterly
Copy link
Member

Closing in favour of #1346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants