Add db schema #1799
Closed
Add db schema #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satterly
force-pushed
the
master
branch
2 times, most recently
from
d73641a
to
4cdfcfb
Compare
satterly
reviewed
Mar 1, 2023
| register_composite( | ||
| 'history', | ||
| name, | ||
| conn, | ||
| globally=True | ||
| ) |
There was a problem hiding this comment.
Replace this with ...
register_composite(
schema + '.history' if schema else 'history',
conn,
globally=True
)
|
Please address the above comments and add some tests to ensure setting a schema works as expected. Thanks. |
|
Btw, you will need to rebase with master so that the tests run. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an addition to be able to use a specific schema with Postgres. We have modified the
base.pyfiles to be functional with a specific schema, we have also added theDATABASE_SCHEMAenvironment variable to be able to configure the schema. By default the variable isnoneso the program will take the public schema.