Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Delete heartbeat #67

Merged
merged 3 commits into from Jan 3, 2017
Merged

Delete heartbeat #67

merged 3 commits into from Jan 3, 2017

Conversation

dex4er
Copy link
Contributor

@dex4er dex4er commented Jan 3, 2017

This is separate tab with heartbeats and possibility of deleting them

Copy link
Member

@satterly satterly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the missing $location. Fix and I'll merge. Thanks.

@@ -815,8 +815,36 @@ alertaControllers.controller('ProfileController', ['$scope', '$auth',
$scope.payload = $auth.getPayload();
}]);

alertaControllers.controller('AboutController', ['$scope', '$timeout', 'config', 'Management', 'Heartbeat',
function($scope, $timeout, config, Management, Heartbeat) {
alertaControllers.controller('HeartbeatsController', ['$scope', '$timeout', 'config', 'Heartbeat',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add $location to the list of injected dependencies.

@dex4er
Copy link
Contributor Author

dex4er commented Jan 3, 2017

@satterly Fixed in other way: I'm just refreshing the heartbeats list.

@satterly satterly merged commit 2803d3a into alerta:master Jan 3, 2017
@satterly
Copy link
Member

satterly commented Jan 3, 2017

Thanks a lot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants