Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GoogleStackDriver] Buffer portion of GCP log not being decoded for AuditLog type #365

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

imranalisyed506
Copy link
Contributor

Problem Description

[GoogleStackDriver] Buffer portion of GCP log not being decoded for AuditLog type

Solution Description

As per google cloud (GCPLogEntry | Cloud Logging | Google Cloud )
documentation the following two logs have type
"type.googleapis.com/google.cloud.audit.AuditLog"
send protoPayload as buffer

image

we noticed for other customers as well when type of log as Audit “type.googleapis.com/google.cloud.audit.AuditLog" protoPayload coming as buffer.
we see all logs coming as type of log as Audit “type.googleapis.com/google.cloud.audit.AuditLog" logs in search console for this customer, if we can get other log types for example “type.googleapis.com/google.cloud.loadbalancing.type.LoadBalancerLogEntry” you will get to see in json format.

Note used: google-proto-files package to decode protobuf to json format for Audit log type only http://type.googleapis.com/google.cloud.audit.AuditLog).

@al-cibot
Copy link

al-cibot commented Apr 8, 2024

CI Service Job Number 970 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 970 -g

Stages Run:

  • PR Test

Copy link
Contributor

@rakhimundhada15 rakhimundhada15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@scott-jones-AlertLogic scott-jones-AlertLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Imran, this looks good; please see my comment about maybe refactoring the protbuf decoding logic out of the pawsGetLogs() method and let me know what you think

collectors/googlestackdriver/collector.js Outdated Show resolved Hide resolved
collectors/googlestackdriver/collector.js Outdated Show resolved Hide resolved
@al-cibot
Copy link

CI Service Job Number 971 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 971 -g

Stages Run:

  • PR Test

Copy link
Contributor

@scott-jones-AlertLogic scott-jones-AlertLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for nitpicking but pls make the audit log decoder a component of the collector itself

collectors/googlestackdriver/collector.js Outdated Show resolved Hide resolved
collectors/googlestackdriver/collector.js Outdated Show resolved Hide resolved
@al-cibot
Copy link

CI Service Job Number 972 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 972 -g

Stages Run:

  • PR Test

@al-cibot
Copy link

CI Service Job Number 973 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 973 -g

Stages Run:

  • PR Test

Copy link
Contributor

@scott-jones-AlertLogic scott-jones-AlertLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super; thank you, Imran! 🙇

@imranalisyed506 imranalisyed506 merged commit 34bf851 into alertlogic:master Apr 17, 2024
2 checks passed
@imranalisyed506 imranalisyed506 deleted the im-gstack-changes1 branch May 21, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants