Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add English Translation #160

Closed
saltsoftdrink opened this issue Feb 2, 2024 · 12 comments
Closed

Add English Translation #160

saltsoftdrink opened this issue Feb 2, 2024 · 12 comments
Labels
enhancement New feature or request low priority low priority

Comments

@saltsoftdrink
Copy link

No description provided.

@alessioC42 alessioC42 added the low priority low priority label Feb 2, 2024
@alessioC42
Copy link
Owner

I assume that 95% of our users speak German and will continue to use the German translation.
However, I personally prefer English UIs and would appreciate a 'select language' feature.
Implementing this feature would require a significant refactoring of the codebase since most of the strings are hard-coded in German. Additionally, many API requests from the SPH are only available in German, either because it's data provided by the school or because of how the API works.
I would like to see a language picker feature in the future, but we need to focus on improving the core functionality and establishing a solid codebase before implementing it. We are currently doing a lot of code cleanup.

@alessioC42 alessioC42 added the enhancement New feature or request label Feb 2, 2024
@serrq
Copy link

serrq commented Mar 19, 2024

I generally help developers to improve their app (you can verifying by yourself my issues over other developers) but I am not a developer and I don't speak German.

This app has potential, and I wish contributing to enhance features.
I want building a better future for children and citizens of tomorrow.

I studied philosophy and literature, and I am Italian native speaker.

Please turn English as high priority.

@alessioC42
Copy link
Owner

I am Italian native speaker

If you don't mind me asking, how did you find the app in the first place? After all, practically every user speaks German because they go to school in Germany/Hesse.
I find it a bit curious that an Italian finds the project just like that

Please turn English as high priority.

May not be high, but a little higher than before.

@serrq
Copy link

serrq commented Mar 19, 2024

I found it in f-droid. But in truth I would like it to be exported to many schools around the world, so as to have an app (client + server) available to local institutions that request it.

I empathize with the student and would like the app to have sincere (permission friendly) permissions and all of this is inside your app.

No surprises because the code is open and data encryption exists. In this regard, I ask: is data encrypted both at rest and in transit (when data leave the device)?

@serrq
Copy link

serrq commented Mar 19, 2024

PS: do you have a demo profile for testing your app as a "student" and as a "teacher"?

Ah, it is in German. 😅

@alessioC42
Copy link
Owner

exported to many schools around the world, so as to have an app (client + server)

I am really sure that this will not happen. While this app may be open source, this school portal (server) is not. We basically take the website, parse the content and display it in the application. (since it is SSR) It is just a way to make it more convenient to access the data on mobile devices and add some features like push notifications. We are basically providing a specialized on-top solution for our needs as a user of the original system, which is Hesse only. Due to this specialization the software is not as easily adaptable to an open or an other backend.

is data encrypted both at rest and in transit

In transit of curse. Because the school portal forces HTTPS, every request must be encrypted. In addition, there is a "second layer encryption" based on RSA within the HTTPS connection for certain sensitive information (such as grades).

At rest, only the password is encrypted on the device. (We cannot save a session or refresh token because the school portal does not work that way. We have to start a new session with the password each time the app starts) Other information is stored in a JSON-like unencrypted format in the app's internal memory. (Currently we do not implement any kind of caching for offline support, so we only store non-sensitive data). An attacker could gain access to the unencrypted storage with a simple debugging interface. With a root shell, he could get the password.

@serrq
Copy link

serrq commented Mar 19, 2024

In transit: for the third layer of encryption (quantum resistant) you can read this article by the SimpleX Chat chief developer.

All is open source. I don't fully understand what he tells, but this is your daily bread. I am pretty sure that you can understanding his words. If interested.

https://simplex.chat/blog/20240314-simplex-chat-v5-6-quantum-resistance-signal-double-ratchet-algorithm.html

@serrq
Copy link

serrq commented Mar 19, 2024

You can take a look also here (TutaCrypt).

https://tuta.com/blog/post-quantum-cryptography

@alessioC42
Copy link
Owner

PS: do you have a demo profile for testing your app as a "student" and as a "teacher"?

Overlooked.

No. I do not have an account other than mine. I have no control over accounts or servers. So I cannot provide an account.

Also, fancy quantum-safe encryption algorithms have to be implemented on the client and server side. Since I have nothing to do with the official school portal maintainers, I cannot really do anything about it. I am just a 16yo who created a mobile version from the existing web version. So I have a lot of limitations.

@serrq
Copy link

serrq commented Mar 19, 2024

Very interesting person. 🙂

@CodeSpoof
Copy link
Collaborator

CodeSpoof commented Mar 20, 2024

No. I do not have an account other than mine. I have no control over accounts or servers. So I cannot provide an account.

Since the userbase is directly taken from the student records, it wouldn't even be possible for schools to provide test-accounts.

@alessioC42
Copy link
Owner

The translations should be done with d194b5c and will be in the next release. Currently there is no in-app language selection, but I will add that soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority low priority
Projects
None yet
Development

No branches or pull requests

4 participants