Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new color themes #103

Merged
merged 14 commits into from
Jan 11, 2024
Merged

Add new color themes #103

merged 14 commits into from
Jan 11, 2024

Conversation

kurwjan
Copy link
Collaborator

@kurwjan kurwjan commented Jan 9, 2024

Jetzt gibt es mehrere Optionen:

  • Standard (Dunkellila)

  • Dynamisch (Material You)

  • Schulfarbe

  • Material 3 Farben (Alle außer ...Accent Farben und dunkellila)

  • Add dynamic color support

  • Add preview?

  • More colours?

+ Added new options in theme changer subsetting
+ Added new color mode notifier
+ Other things in themes.dart, etc.
@kurwjan kurwjan added the enhancement New feature or request label Jan 9, 2024
@kurwjan kurwjan self-assigned this Jan 9, 2024
@kurwjan
Copy link
Collaborator Author

kurwjan commented Jan 9, 2024

Lanis-Dunkel-Türkis:
image
Neue Optionen:
image

@kurwjan kurwjan marked this pull request as ready for review January 9, 2024 21:41
@kurwjan kurwjan changed the title Add new color mode(s) Add new color themes Jan 9, 2024
@kurwjan kurwjan mentioned this pull request Jan 9, 2024
7 tasks
Copy link
Owner

@alessioC42 alessioC42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_getSchoolTheme wird bei jedem client login ausgeführt. Es sollte, jedoch nur bei einer Erstanmeldung geschehen. Weil sich das nicht ändert macht es mehr sinn, das zur speichern.

Sobald ich die Einstellungen laden will kommt die Fehlermeldung:
error_theme.txt

@kurwjan
Copy link
Collaborator Author

kurwjan commented Jan 10, 2024

Das zu speichern ist ne gute Idee. Das mit den Fehler passiert, da das Gerät nicht Material You unterstützt und ich habe den Check, ob das existiert, für die Preview nicht eingebaut.

@kurwjan
Copy link
Collaborator Author

kurwjan commented Jan 11, 2024

image

@alessioC42 alessioC42 merged commit 4f8a8fe into main Jan 11, 2024
@alessioC42 alessioC42 deleted the dynamic_color branch January 11, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants