Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kill functionality #122

Merged
merged 4 commits into from
Dec 11, 2022
Merged

Fix kill functionality #122

merged 4 commits into from
Dec 11, 2022

Conversation

ashish-r
Copy link
Contributor

@ashish-r ashish-r commented May 19, 2022

@ashish-r
Copy link
Contributor Author

@alewin @zant please review

@federicoWax
Copy link

Porque aun no esta este fix :(

@ghost
Copy link

ghost commented Nov 4, 2022 via email

@optimista
Copy link

optimista commented Nov 22, 2022

Also looking for review and merge, implementing @ashish-r's changes through patch-package for now.

In Firefox not updating of the state blocked the whole thread as the following try couldn't continue (recognizing the previous worker process as still running).

The patch-package file to be found here: https://gist.github.com/optimista/69e168b9eb63921ce188ef555c709f4d

@alewin
Copy link
Owner

alewin commented Dec 11, 2022

Thanks @ashish-r
Please forgive my long absence 🙏 , I'm back :)

cc: @optimista @TianJianJun727 @federicoWax @LorhanSohaky @zant

@alewin alewin merged commit 19d2f24 into alewin:master Dec 11, 2022
@ashish-r
Copy link
Contributor Author

ashish-r commented Dec 14, 2022

Hey @alewin thanks for merging the PR. I see that the release workflow failed in the Setup pnpm config. Do we manually release the package? Or should I check the workflow failure and patch the same?

PS: We need to upgrade the node version here: https://github.com/alewin/useWorker/blob/master/.github/workflows/release.yml

@sakthi0803
Copy link

@ashish-r
Are the above fixes deployed?

@ghost
Copy link

ghost commented Mar 2, 2023 via email

@ashish-r
Copy link
Contributor Author

ashish-r commented Mar 3, 2023

Hi @alewin, thanks for merging the PR, the fix is not yet released. Please let me know if there is anything else you need.

@Pipe-Runner
Copy link

I wasted hours setting my code up for this lib, and now I discover I can't kill workers. It makes things completely useless for me.
For anyone else who wants to get a quick solution from this, use https://github.com/Shopify/quilt/blob/main/packages/react-web-worker/README.md. Much more stable and feature-complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants