-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kill functionality #122
Conversation
Porque aun no esta este fix :( |
这是来自QQ邮箱的假期自动回复邮件。你好,我最近正在休假中,无法亲自回复你的邮件。我将在假期结束后,尽快给你回复。
|
Also looking for review and merge, implementing @ashish-r's changes through In Firefox not updating of the state blocked the whole thread as the following try couldn't continue (recognizing the previous worker process as still running). The |
Thanks @ashish-r cc: @optimista @TianJianJun727 @federicoWax @LorhanSohaky @zant |
Hey @alewin thanks for merging the PR. I see that the release workflow failed in the PS: We need to upgrade the node version here: https://github.com/alewin/useWorker/blob/master/.github/workflows/release.yml |
@ashish-r |
这是来自QQ邮箱的假期自动回复邮件。你好,我最近正在休假中,无法亲自回复你的邮件。我将在假期结束后,尽快给你回复。
|
Hi @alewin, thanks for merging the PR, the fix is not yet released. Please let me know if there is anything else you need. |
I wasted hours setting my code up for this lib, and now I discover I can't kill workers. It makes things completely useless for me. |
Fix for the issue reported with the kill functionality reported in the below issues:
kill()
does not fully reset state #119