Feature/issues 18 typescript support #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pigotz
reviewed
Mar 18, 2020
There was a problem hiding this comment.
The overall PR looks good, I just pointed some issues for further improvements.
Also, the JSdoc comments are useful but, to me, out of the scope for this PR.
Next steps could possibly be:
- Move all of the source code to TS
- Generate a real JSdoc out of those comments
Comment on lines
-9
to
-11
| "build": "microbundle src/index.js && npm run copy", | ||
| "build": "microbundle src/index.js", | ||
| "dev": "microbundle watch", | ||
| "copy": "cp package.json dist/ && cp README.md dist/", |
There was a problem hiding this comment.
I would restore this and make two changes:
- Use a cross platform copy command (this won't work on Windows) like cpx
- Copy the
index.d.tsfile too
There was a problem hiding this comment.
but would that be redundant? I already keep these files inside the root
There was a problem hiding this comment.
Sounds ok for the index.d.ts file. What about the cpx package?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo