Feature: transform the display #43

alex-courtis · 2022-06-06T02:12:28Z

Closes #41

@anandubey let's continue discussions in here.

alex-courtis

This is looking good and the 180 flip is working.

TODO

fixes mentioned in review
Actually apply the Cfg value in desire_transform
Print the transformation information in info.c
Add transformation to CLI; merge etc. looks complete so I expect it should Just Work

src/cfg.cpp

alex-courtis · 2022-06-06T02:37:35Z

src/cfg.cpp

+				cfg_user_mode_free(user_transform);
+				continue;
+			}
+			if (!parse_node_val_int(transform, "DEGREE", &user_transform->transform, "TRANSFORM", user_transform->name_desc)) {


We will need to be more strict about the value here: only a few values are applicable, and we need to account for flipped.

We can use a similar scheme to sway:

Can be one of "90", "180", "270" for rotation; or "FLIPPED", "FLIPPED-90", "FLIPPED-180", "FLIPPED-270" to apply a rotation and flip, or "NORMAL" to apply no transform.

convert.c methods similar to auto_scale_val and auto_scale_name will need to be created to perform that validation and conversion.

Need time to figure out this one. Not getting enough time from work :(

There is no rush

inc/cfg.h

src/cfg.cpp

src/head.c

src/layout.c

- ability to specify transform value in terms of int - ability to hot reload - prints info value with transform info - accepts transform through cmd line (does not work - still broken)

anandubey · 2022-07-04T12:57:16Z

Things left to do:

cmd line does not work properly.
flipped transform was a bit buggy in my testing.

Thank you for waiting. Last month, I was super occupied at work.

alex-courtis

Made a few fixes. I don't have access you push to your repo, so here are some patches you can git apply ... in order.
0001-formatting.patch.txt
0002-remove-head.tranform-always-use-desired-and-current.patch.txt
0003-assorted-fixes-for-transform-read-write.patch.txt

This is working quite nicely now.

Tested OK:

value from cfg.yaml
set / reset from CLI
delete from CLI
write from CLI

TODO:

user friendly strings -> enums Feature: transform the display #43 (comment)
doc: readme and man page
consistency in naming: always use "transform", not "rotation"

src/cfg.cpp

alex-courtis · 2022-07-11T04:37:58Z

src/cfg.cpp

+				cfg_user_mode_free(user_transform);
+				continue;
+			}
+			if (!parse_node_val_int(transform, "DEGREE", &user_transform->transform, "TRANSFORM", user_transform->name_desc)) {


There is no rush

src/layout.c

alex-courtis · 2022-07-11T04:51:03Z

src/layout.c

+    if (!head->desired.enabled)
+        return;
+
+    // attempt to find a mode


/nit "attempt to find a transform"

src/cfg.cpp

alex-courtis · 2022-07-11T05:05:51Z

There is a large refactor incoming, which greatly affects cfg.

I am happy to merge it to your repo.

I'll need to have push access... applying a large merge as a patch is not viable.

anandubey · 2022-07-13T13:32:45Z

I have added you to the collaborators list. I hope now you will have the push access.

alex-courtis · 2022-07-16T01:36:11Z

I have added you to the collaborators list. I hope now you will have the push access.

Thanks @anandubey

I'll merge master to your fork after https://github.com/alex-courtis/way-displays/tree/49-yaml-schemas is merged.

alex-courtis · 2022-07-26T02:59:07Z

I'll merge master to your fork after https://github.com/alex-courtis/way-displays/tree/49-yaml-schemas is merged.

master at 1.6.0 has been merged, along with the patches above.

The large change resulted from refactors when adding the IPC API. A lot of src/cfg was moved to src/marshalling

I've pre-emptively added !!transform to the YAML schema
You'll need test it with the example client when you have finished adding all the TRANSFORM enums.

alex-courtis · 2022-08-28T02:30:35Z

Nudge @anandubey

Any updates on this one?

This is really close to complete and I look forward to releasing it!

anandubey · 2022-09-04T09:51:27Z

@alex-courtis Sorry for zoning out on this. Started my new job on 1st Aug. It's a rust dev role, so all my weekends are going in that. I will try my best to finish it this week.

alex-courtis · 2022-09-04T23:56:20Z

@alex-courtis Sorry for zoning out on this. Started my new job on 1st Aug. It's a rust dev role, so all my weekends are going in that. I will try my best to finish it this week.

No worries. There is no hurry at all.

Good luck in the new role!

edrex · 2023-02-28T07:33:13Z

Thanks for your work on this @anandubey, and totally understand about prioritizing paid job.

It would be great to get output transforms in tho. Do you anticipate having time to get this merge ready going forward, or alternatively, would you be open to handing it off?

If C was fresher in my mind I would volunteer (and my ADHD brain likes to say yes) but I shouldn't.

alex-courtis · 2023-03-04T01:34:52Z

would you be open to handing it off?

That would be fantastic!

I just cannot allocate the time to finish this one off...

If C was fresher in my mind I would volunteer (and my ADHD brain likes to say yes) but I shouldn't.

make cppcheck might be useful to you.

way-displays is also set up for ccls live checking in the editor. Here's my config for neovim lsp: https://github.com/alex-courtis/arch/blob/bd011f38a006cecc2f32526b944d145e164dd7d2/config/nvim/lua/amc/plugins/lsp.lua#L11

edrex · 2023-03-04T05:16:34Z

make cppcheck

cool!

way-displays is also set up for ccls live checking in the editor.

alright! I use helix which uses clangd by default but I can change it in languages.toml.

alex-courtis · 2023-03-05T00:35:29Z

alright! I use helix which uses clangd by default but I can change it in languages.toml.

All good; clang is preferred and used by ccls. gcc is only used by default for legacy packaging reasons.

alex-courtis · 2023-03-05T01:32:49Z

Added development information to https://github.com/alex-courtis/way-displays/blob/master/CONTRIBUTING.md

edrex · 2023-04-10T22:19:04Z

Want to try to get this in before #83? I would be willing to do a testing pass and make any needed changes if you have time for code review. I think I basically remember how to C :)

I'll be on a road trip/camping Apr 14-23 though, so we'll see how much keyboard time I get.

alex-courtis · 2023-04-10T22:52:09Z

Want to try to get this in before #83? I would be willing to do a testing pass and make any needed changes if you have time for code review. I think I basically remember how to C :)

I'll be on a road trip/camping Apr 14-23 though, so we'll see how much keyboard time I get.

Oh yes please!

I've added a lot of unit tests on master, so that should make this easier RE merge etc.

Edit: Rather than trying to merge this branch it might be easier just to create a new branch and manually copy the relevant bits. Things have changed a lot since this was raised.

alex-courtis · 2023-08-29T06:55:25Z

#133

anandubey added 2 commits May 16, 2022 21:17

hard-coded transform with same value for all outputs

284371d

transform api's for config file

706e18a

alex-courtis commented Jun 6, 2022

View reviewed changes

transform support on cfg file

f5f3e46

- ability to specify transform value in terms of int - ability to hot reload - prints info value with transform info - accepts transform through cmd line (does not work - still broken)

alex-courtis commented Jul 11, 2022

View reviewed changes

alex-courtis added 8 commits July 26, 2022 12:03

transform: fix formatting

7c82760

transform: always use desired and current

0db6f87

transform: assorted cfg user_transform fixes

beb9750

merge 1.6.0

28fb078

merge 1.6.0

3bb1dd5

Merge branch 'anandubey-1.6.0-merge'

16ac4fc

Merge remote-tracking branch 'upstream/master'

18c7fc1

merge 1.6.0

3781d55

alex-courtis mentioned this pull request Apr 10, 2023

1.8.0 Roadmap #84

Closed

9 tasks

alex-courtis mentioned this pull request May 6, 2023

1.9.0 Roadmap #85

Closed

6 tasks

alex-courtis modified the milestones: 1.9.0 Roadmap, 1.9 Jun 24, 2023

alex-courtis closed this Aug 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: transform the display #43

Feature: transform the display #43

alex-courtis commented Jun 6, 2022 •

edited

alex-courtis left a comment •

edited

alex-courtis Jun 6, 2022

anandubey Jul 4, 2022

alex-courtis Jul 11, 2022

anandubey commented Jul 4, 2022 •

edited by alex-courtis

alex-courtis left a comment •

edited

alex-courtis Jul 11, 2022

alex-courtis Jul 11, 2022

alex-courtis commented Jul 11, 2022

anandubey commented Jul 13, 2022 •

edited

alex-courtis commented Jul 16, 2022

alex-courtis commented Jul 26, 2022

alex-courtis commented Aug 28, 2022

anandubey commented Sep 4, 2022

alex-courtis commented Sep 4, 2022

edrex commented Feb 28, 2023

alex-courtis commented Mar 4, 2023 •

edited

edrex commented Mar 4, 2023 •

edited

alex-courtis commented Mar 5, 2023 •

edited

alex-courtis commented Mar 5, 2023

edrex commented Apr 10, 2023

alex-courtis commented Apr 10, 2023 •

edited

alex-courtis commented Aug 29, 2023

Feature: transform the display #43

Feature: transform the display #43

Conversation

alex-courtis commented Jun 6, 2022 • edited

alex-courtis left a comment • edited

Choose a reason for hiding this comment

alex-courtis Jun 6, 2022

Choose a reason for hiding this comment

anandubey Jul 4, 2022

Choose a reason for hiding this comment

alex-courtis Jul 11, 2022

Choose a reason for hiding this comment

anandubey commented Jul 4, 2022 • edited by alex-courtis

alex-courtis left a comment • edited

Choose a reason for hiding this comment

alex-courtis Jul 11, 2022

Choose a reason for hiding this comment

alex-courtis Jul 11, 2022

Choose a reason for hiding this comment

alex-courtis commented Jul 11, 2022

anandubey commented Jul 13, 2022 • edited

alex-courtis commented Jul 16, 2022

alex-courtis commented Jul 26, 2022

alex-courtis commented Aug 28, 2022

anandubey commented Sep 4, 2022

alex-courtis commented Sep 4, 2022

edrex commented Feb 28, 2023

alex-courtis commented Mar 4, 2023 • edited

edrex commented Mar 4, 2023 • edited

alex-courtis commented Mar 5, 2023 • edited

alex-courtis commented Mar 5, 2023

edrex commented Apr 10, 2023

alex-courtis commented Apr 10, 2023 • edited

alex-courtis commented Aug 29, 2023

alex-courtis commented Jun 6, 2022 •

edited

alex-courtis left a comment •

edited

anandubey commented Jul 4, 2022 •

edited by alex-courtis

alex-courtis left a comment •

edited

anandubey commented Jul 13, 2022 •

edited

alex-courtis commented Mar 4, 2023 •

edited

edrex commented Mar 4, 2023 •

edited

alex-courtis commented Mar 5, 2023 •

edited

alex-courtis commented Apr 10, 2023 •

edited