Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Insert tree validation #463

Merged
merged 18 commits into from
Jan 29, 2021
Merged

Insert tree validation #463

merged 18 commits into from
Jan 29, 2021

Conversation

alex-dukhno
Copy link
Owner

Closes #459

Description

traversing InsertTreeNode and validate if expression tree could be executed

Is it a feature that change user experience?

no

Client output

no

@coveralls
Copy link

coveralls commented Jan 20, 2021

Pull Request Test Coverage Report for Build 521793891

  • 2494 of 2753 (90.59%) changed or added relevant lines in 79 files are covered.
  • 446 unchanged lines in 25 files lost coverage.
  • Overall coverage decreased (-5.08%) to 84.185%

Changes Missing Coverage Covered Lines Changed/Added Lines %
data/binary/src/lib.rs 18 19 94.74%
deprecated/query_execution_deprecated/query_executor/src/dml/insert.rs 0 1 0.0%
deprecated/query_execution_deprecated/query_executor/src/dml/select.rs 0 1 0.0%
deprecated/query_planning_deprecated/query_planner/src/lib.rs 1 2 50.0%
entities/repr/src/lib.rs 12 13 92.31%
data_definition/execution_plan/src/lib.rs 3 5 60.0%
deprecated/query_analysis_deprecated/description/src/lib.rs 20 22 90.91%
query_analyzer/src/dynamic_tree_builder.rs 20 23 86.96%
read_query/executor/src/lib.rs 6 9 66.67%
write_query/executor/src/lib.rs 52 55 94.55%
Files with Coverage Reduction New Missed Lines %
deprecated/ast/src/operations.rs 1 94.26%
deprecated/binder_deprecated/src/lib.rs 1 93.58%
deprecated/query_execution_deprecated/expr_eval/src/static_expr.rs 1 93.02%
deprecated/query_planning_deprecated/plan/src/lib.rs 1 48.98%
deprecated/query_planning_deprecated/query_planner/src/update.rs 1 73.33%
entities/types/src/lib.rs 1 75.76%
deprecated/ast/src/values.rs 2 93.68%
deprecated/query_planning_deprecated/query_planner/src/lib.rs 2 75.0%
entities/definition/src/lib.rs 2 92.59%
server/node/src/bin.rs 2 25.0%
Totals Coverage Status
Change from base Build 490442456: -5.08%
Covered Lines: 9885
Relevant Lines: 11742

💛 - Coveralls

@alex-dukhno alex-dukhno marked this pull request as ready for review January 29, 2021 19:36
@alex-dukhno alex-dukhno merged commit 97e9641 into master Jan 29, 2021
@alex-dukhno alex-dukhno deleted the insert-tree-validation branch January 29, 2021 19:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement TypeValidation of InsertTreeNode
2 participants