Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for the headline structure of the readme #46

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

rpkoller
Copy link
Contributor

@rpkoller rpkoller commented Feb 9, 2021

The readme had an incoherent headline structure which made the comprehension a bit difficult. It was cumbersome to distinguish between the vagrant part and the docker part due to the fact the vagrant was an h1 while docker was an h2. right before the docker part there were the configuration and usage parts which were also an h1 making the impression that all steps might be necessary even though you just want to use the docker part. instead they are two complete different processes.
therefor i would suggest make the vagrant and docker headlines each a h2 so the only h1 in the document is the visual regression testing made easy. also making all the sub headlines of vagrant and docker a h3. that would be a quick and easy fix to make the readme a bit easier to comprehend.

The readme had an incoherent headline structure which made the comprehension a bit difficult.  It was cumbersome to distinguish between the `vagrant` part and the `docker` part due to the fact the `vagrant` was an `h1` while `docker` was an `h2`. and right before the docker part there were the `configuration` and `usage` parts which were also an `h1` making the impression that all steps might be necessary even though you just want to use the `docker` part. instead they are two complete different processes. therefor i would suggest make the vagrant and docker headlines each a `h2` so the only `h1` in the document is the `visual regression testing made easy`. and all the sub headlines of `vagrant` and `docker`  a `h3`. that would be a quick and easy fix to make the readme a bit easier to comprehend.
@rpkoller rpkoller changed the title Changes for the headline structure Changes for the headline structure of the readme Feb 9, 2021
@alex-moreno
Copy link
Owner

Thanks a lot for your contribution @rpkoller

@alex-moreno alex-moreno merged commit 9d47cbb into alex-moreno:main Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants