Faster multi agent vulkan rendering #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-petrenko
approved these changes
Apr 13, 2021
| } | ||
|
|
||
| sceneObjectInfo.objectPtr->addFeature<V4RDrawable>( |
There was a problem hiding this comment.
So the change here is that instead of having one Magnum feature for every pair agent-3D object we only have one feature per object. And it handles its own update in all "render envs", i.e. for all agents at once.
I like this! Indeed this should minimize the amount of work on Magnum side, and it makes more sense in general.
I trust you that it works, good contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature of lists instead of a list of features is more efficient when there are a lot of agents. In my testing, this change does not really matter for 1, 2, or 4 agents, but starts helping at 8 or more.