Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isaac gym docs w/o videos #234

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

andrewzhang505
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Base: 80.33% // Head: 80.30% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (fe164bc) compared to base (4f8dc4f).
Patch coverage: 50.00% of modified lines in pull request are covered.

❗ Current head fe164bc differs from pull request most recent head 71dd9fa. Consider uploading reports for the commit 71dd9fa to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              sf2     #234      +/-   ##
==========================================
- Coverage   80.33%   80.30%   -0.04%     
==========================================
  Files          90       90              
  Lines        7378     7387       +9     
==========================================
+ Hits         5927     5932       +5     
- Misses       1451     1455       +4     
Impacted Files Coverage Δ
sample_factory/huggingface/huggingface_utils.py 15.62% <16.66%> (-1.33%) ⬇️
sample_factory/enjoy.py 74.55% <33.33%> (-0.45%) ⬇️
sample_factory/cfg/arguments.py 83.47% <100.00%> (+0.13%) ⬆️
sample_factory/utils/utils.py 59.21% <100.00%> (+0.29%) ⬆️
sample_factory/algo/learning/learner.py 87.85% <0.00%> (-0.16%) ⬇️
sample_factory/pbt/population_based_training.py 85.83% <0.00%> (+0.41%) ⬆️
sample_factory/algo/sampling/batched_sampling.py 95.85% <0.00%> (+1.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@alex-petrenko alex-petrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feature, thank you!!



def get_top_level_script():
return argv[0].split("sample-factory/")[-1][:-3].replace("/", ".")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is maybe okay for now, but it will fail if the train script is not in Sample Factory codebase (like with quadrotors for example)

One idea is to get the module path directly from the module object (you can do module.spec.name)

@alex-petrenko alex-petrenko merged commit f7de3d8 into alex-petrenko:sf2 Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants