Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forced deletion #18

Closed
wants to merge 13 commits into from
Closed

Add forced deletion #18

wants to merge 13 commits into from

Conversation

nikkiii
Copy link
Contributor

@nikkiii nikkiii commented Dec 1, 2015

Trashed items can be deleted by sending a DELETE request to https://www.amazon.com/drive/v1/nodes/{id}, this PR implements it.

@nikkiii
Copy link
Contributor Author

nikkiii commented Dec 1, 2015

It looks like the features merged with the other branch too... If you have any suggestions on how to only make it merge the permanent deletion change, I'd be happy to resubmit it if this breaks it in any way.

@alex-phillips
Copy link
Owner

I'll review the stream PR first. Once that gets merged in, just rebase this branch and push it up and the only diff should be the delete changes.

As far as permanently deleting a node, I don't see this documented anywhere. How did you find that this endpoint worked?

Thanks for the interest in the project!

@nikkiii
Copy link
Contributor Author

nikkiii commented Dec 1, 2015

Well, I guess the url isn't correct in the implementation and I was mistaken to think it worked (I tried it and it seemed to, but that might've been a mixup), but it does exist on the frontend and probably exists SOMEWHERE on the other host.

I'm looking into it now, probably going to have to close this and revert it since I don't think it works :(

@nikkiii
Copy link
Contributor Author

nikkiii commented Dec 1, 2015

After some digging it seems I was mistaken in thinking that it'd work here.

From the developer forums:

As of right now permanently deleting content is not available through the Amazon Cloud Drive API.
You can however use the "trash" API to soft delete a node putting contents in the customer's recycle bin.

I'll close this since it doesn't work.

@nikkiii nikkiii closed this Dec 1, 2015
@nikkiii nikkiii deleted the deletion branch December 1, 2015 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants