Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapsing the menu on mobile is too hard #154

Closed
undergroundwires opened this issue Feb 26, 2020 · 3 comments
Closed

Collapsing the menu on mobile is too hard #154

undergroundwires opened this issue Feb 26, 2020 · 3 comments

Comments

@undergroundwires
Copy link
Contributor

undergroundwires commented Feb 26, 2020 •
edited

image
alex-shpak added a commit that referenced this issue Feb 27, 2020
@alex-shpak
#154, Add menu overlay over content to hide menu on click
a722f74
@alex-shpak
Copy link
Owner

Hi!
I added transparent overlay over content that would hide menu on click.

@alex-shpak
Copy link
Owner

Hi again!
Did it work for you? :)

@undergroundwires
Copy link
Contributor Author

Thanks @alex-shpak, it works pretty good. I tested on Firefox + Chrome on Windows & Linux & Android. It looked as expected everywhere except android Firefox, there I got a gray overlay while touching, it disappears after I stop touching (when the menu disappears). Maybe outline: none; is needed. I can test it with that property later on and come back. For now I'm closing the issue. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alex-shpak @undergroundwires