#134, Focus search field by pressing s or / #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-shpak
reviewed
Jan 19, 2020
|
|
||
| function isHotkey(character) { | ||
| const dataHotkeys = input.getAttribute('data-hotkeys') || ''; | ||
| const hotkeys = dataHotkeys.split(' '); |
There was a problem hiding this comment.
🤔Maybe can be shortened to:
return dataHotkeys.indexOf(character) >= 0
Considering any char in dataHotkeys as possible trigger.
There was a problem hiding this comment.
I'm not sure about making any key trigger the search field though, as that might have to be reverted in case another shortcut was ever added.
|
Looks good 👍 |
tyler71
pushed a commit
to tyler71/hugo-book
that referenced
this pull request
Jan 22, 2020
* alex-shpak#134, Focus search field by pressing s or / * alex-shpak#134, Refactoring away an array loop using indexOf
tyler71
pushed a commit
to tyler71/hugo-book
that referenced
this pull request
Jan 22, 2020
* alex-shpak#134, Focus search field by pressing s or / * alex-shpak#134, Refactoring away an array loop using indexOf
tyler71
pushed a commit
to tyler71/hugo-book
that referenced
this pull request
Jan 22, 2020
* alex-shpak#134, Focus search field by pressing s or / * alex-shpak#134, Refactoring away an array loop using indexOf
tyler71
pushed a commit
to tyler71/hugo-book
that referenced
this pull request
Jan 22, 2020
* alex-shpak#134, Focus search field by pressing s or / * alex-shpak#134, Refactoring away an array loop using indexOf
tyler71
pushed a commit
to tyler71/hugo-book
that referenced
this pull request
Jan 22, 2020
* alex-shpak#134, Focus search field by pressing s or / * alex-shpak#134, Refactoring away an array loop using indexOf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #134 by emulating GitHub's behavior.
Tested in Chrome, FF and IE 11.