fix keeweb#656: prevent master password autocomplete

alex-shpak · Jun 23, 2017 · 18fa9e1 · 18fa9e1
1 parent bae426d
commit 18fa9e1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/app/templates/open.hbs b/app/templates/open.hbs
@@ -64,11 +64,16 @@
         {{/if}}
     </div>
     <div class="open__pass-area">
+        <div class="hide">
+            {{!-- we need these inputs to screw browsers passwords autocompletion --}}
+            <input type="text" style="display:none" name="username">
+            <input type="password" style="display:none" name="password">
+        </div>
         <div class="open__pass-warn-wrap">
             <div class="open__pass-warning muted-color invisible"><i class="fa fa-exclamation-triangle"></i> {{res 'openCaps'}}</div>
         </div>
         <div class="open__pass-field-wrap">
-            <input class="open__pass-input" type="password" size="30" autocomplete="off" maxlength="1024"
+            <input class="open__pass-input" type="password" size="30" autocomplete="new-password" maxlength="1024"
                    placeholder="{{res 'openClickToOpen'}}" readonly />
             <div class="open__pass-enter-btn"><i class="fa fa-level-down fa-rotate-90"></i></div>
             <div class="open__pass-opening-icon"><i class="fa fa-spinner fa-spin"></i></div>

diff --git a/release-notes.md b/release-notes.md
@@ -3,6 +3,7 @@ Release notes
 ##### v1.6.0 (WIP)
 `+` desktop apps integrity protection  
 `+` auto-lock on computer lock  
+`*` prevent master password autocomplete  
 `-` fixed auto-closing tab when starting from link  
 `-` fixed tray icon click crash