Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 1.9 support for undocumented addition of contains_aggregate #344

Closed

Conversation

nealtodd
Copy link
Contributor

In Django commit afe0bb7 and check for a contains_aggregate is made which assumes that attribute is present.

This causes an exception when ExtraJoinRestriction is checked:

File ".../django/db/models/sql/where.py", line 157, in _contains_aggregate
    return obj.contains_aggregate
AttributeError: 'ExtraJoinRestriction' object has no attribute 'contains_aggregate'

This causes three errors in the taggit tests.

This PR sets the attribute to False in ExtraJoinRestriction which, other than preventing the error, I think is benign for Django < 1.9 and >= 1.9.

@frewsxcv
Copy link
Collaborator

Closing in favor of #352

@frewsxcv frewsxcv closed this Oct 25, 2015
@frewsxcv
Copy link
Collaborator

Just released 0.17.2 that has Django 1.9 fixes

https://pypi.python.org/pypi/django-taggit/0.17.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants