Add extra_filters argument to the manager's most_common method #422

Merged
merged 2 commits into from Jul 12, 2016

Projects

None yet

3 participants

@payamnj
Contributor
payamnj commented Jul 7, 2016

No description provided.

@payamnj payamnj Allow users to add extra filters to the queryset when they want to ge…
…t the most common tags.
17a8a82
@frewsxcv
Collaborator
frewsxcv commented Jul 7, 2016

Are you able to add a test for this? It could be very basic. If not, no worries.

@payamnj
Contributor
payamnj commented Jul 7, 2016

@frewsxcv Yes, I think I can add a test for it.

@codecov-io
codecov-io commented Jul 7, 2016 edited

Current coverage is 90.70%

Merging #422 into master will not change coverage

@@             master       #422   diff @@
==========================================
  Files             8          8          
  Lines           699        699          
  Methods           0          0          
  Messages          0          0          
  Branches        114        114          
==========================================
  Hits            634        634          
  Misses           53         53          
  Partials         12         12          

Powered by Codecov. Last updated by 55ea399...67b6af7

@payamnj payamnj tests for taggable manager most_common method with extra filters
67b6af7
@frewsxcv
Collaborator

Thanks @payamnj! 🎊

@frewsxcv frewsxcv merged commit 8b18ee7 into alex:master Jul 12, 2016

3 checks passed

codecov/patch 100% of diff hit (target 90.70%)
Details
codecov/project 90.70% (+0.00%) compared to 55ea399
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@frewsxcv
Collaborator

Version 0.20.2 has been released which includes this change.

@payamnj
Contributor
payamnj commented Jul 12, 2016

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment