Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipcRenderer.postMessage should throw error when contextIsolated is enabled #5

Closed
4 tasks done
wong2 opened this issue Oct 18, 2023 · 1 comment
Closed
4 tasks done
Labels
bug Something isn't working

Comments

@wong2
Copy link

wong2 commented Oct 18, 2023

Describe the bug

It wasted me hours figuring out why ipcRenderer.postMessage has no effect at all. 😂
Then I read the source code and found out if contextIsolated is enabled, the function just returns silently, which I believe is a bad practice.

postMessage(channel, message, transfer) {

Electron-Toolkit Version

2.0.0

Electron Version

25.6.0

Validations

@wong2 wong2 added the bug Something isn't working label Oct 18, 2023
@alex8088
Copy link
Owner

preload@3.0.0 is out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants