Default resolve condition "node" for preload causes incompatible node versions of modules to be loaded when nodeIntegration is disabled

[shayded-exe]

Describe the bug

Preload should not have "node" set as a resolve condition by default, as there's no way to disable it because vite's mergeConfig will merge arrays.

My preload uses the uuid module. Because of this condition, it bundles the node version module instead of the browser version, which breaks because it requires the crypto module and I have node integration disabled.

Electron-Vite Version

1.0.24

Electron Version

22

Vite Version

4.1.1

Validations

• Follow the Code of Conduct.
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

[alex8088]

@shayded-exe I'm also thinking about this. You can externalize it first(sandbox needs to be disabled).

[shayded-exe]

Disabling sandbox isn't an option for me.

[alex8088]

The next version will remove this condition for preload.

[alex8088]

@shayded-exe You can set resolve.condition to [].

[shayded-exe]

@alex8088 That doesn't overwrite the value though. Vite's mergeConfig concats the arrays.

See here:
https://github.com/vitejs/vite/blob/main/packages/vite/src/node/utils.ts#L1038

[alex8088]

new ver 1.0.25 is out!

[shayded-exe]

Thank you! 😃