Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.0.0 #47

Closed
tejashah88 opened this issue Jan 30, 2017 · 5 comments
Closed

Release 3.0.0 #47

tejashah88 opened this issue Jan 30, 2017 · 5 comments
Labels

Comments

@tejashah88
Copy link
Member

tejashah88 commented Jan 30, 2017

Considering how many changes we've all contributed to this library, wouldn't it make sense to bump the version to 2.4.0 from 2.3.1, instead of 2.3.2?

@tejashah88 tejashah88 changed the title Next Release versioning Next release versioning Jan 30, 2017
@dblock
Copy link
Collaborator

dblock commented Jan 31, 2017

We should follow semver IMHO. If there're breaking changes, yes. Otherwise quantity of changes shouldn't be a criteria.

@dblock dblock changed the title Next release versioning Release v. Next Jan 31, 2017
@mreinstein
Copy link
Contributor

the general rule of them is if you push a new feature or capability but don't break the existing api, you can update the minor version. If you're not adding anything new, not breaking the api, update the patch number.

@dblock
Copy link
Collaborator

dblock commented Feb 4, 2017

At the very least we're going to require alexa-app >= 2.4.0, so maybe a major bump is warranted here.

I'm also tempted to release it as 2.5.0, just because that will match alexa-app 2.5.0, but maybe that's unnecessary. Appreciate everybody's thoughts.

Only waiting on #64 to be merged and we can cut a release here.

@dblock
Copy link
Collaborator

dblock commented Feb 5, 2017

I got some docs in #69, otherwise I feel this is ready to go right on the tail of an alexa-app release (will need to change package.json minimum version for alexa-app).

@dblock dblock changed the title Release v. Next Release 2.4.0 Feb 5, 2017
@dblock dblock changed the title Release 2.4.0 Release 3.0.0 Feb 6, 2017
@dblock dblock closed this as completed in 16f7ad5 Feb 6, 2017
@dblock
Copy link
Collaborator

dblock commented Feb 6, 2017

Released as 3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants