Added documentation for building SSML responses #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
reviewed
Aug 19, 2017
README.md
Outdated
| @@ -247,6 +248,49 @@ async response.fail(String message) | |||
| return response.say("OK").send() | |||
| ``` | |||
|
|
|||
| #### Building SSML Responses | |||
|
|
|||
| The [ssml-builder](https://github.com/mandnyc/ssml-builder) library is a great tool for building SSML responses. While it's meant to be a general purpose SSML builder, it does supports [Amazon-specific SSML tags](https://github.com/mandnyc/ssml-builder#amazon-ssml-specific-tags). See the [official Amazon documentation](https://developer.amazon.com/public/solutions/alexa/alexa-skills-kit/docs/speech-synthesis-markup-language-ssml-reference) for which SSML tags you can use. | |||
There was a problem hiding this comment.
it "does support" (remove s) or "supports"
dblock
reviewed
Aug 19, 2017
README.md
Outdated
| The [ssml-builder](https://github.com/mandnyc/ssml-builder) library is a great tool for building SSML responses. While it's meant to be a general purpose SSML builder, it does supports [Amazon-specific SSML tags](https://github.com/mandnyc/ssml-builder#amazon-ssml-specific-tags). See the [official Amazon documentation](https://developer.amazon.com/public/solutions/alexa/alexa-skills-kit/docs/speech-synthesis-markup-language-ssml-reference) for which SSML tags you can use. | ||
|
|
||
| Example using basic SSML tags: | ||
| ```javascript |
There was a problem hiding this comment.
Add an empty line? Let it breathe :)
dblock
reviewed
Aug 19, 2017
README.md
Outdated
| @@ -247,6 +248,49 @@ async response.fail(String message) | |||
| return response.say("OK").send() | |||
| ``` | |||
|
|
|||
| #### Building SSML Responses | |||
|
|
|||
| The [ssml-builder](https://github.com/mandnyc/ssml-builder) library is a great tool for building SSML responses. While it's meant to be a general purpose SSML builder, it does supports [Amazon-specific SSML tags](https://github.com/mandnyc/ssml-builder#amazon-ssml-specific-tags). See the [official Amazon documentation](https://developer.amazon.com/public/solutions/alexa/alexa-skills-kit/docs/speech-synthesis-markup-language-ssml-reference) for which SSML tags you can use. | |||
There was a problem hiding this comment.
This is a nitpick, but we could be more "directed" with just "Use ssml-builder to build SSML responses." Shorter and to the point.
|
Needs some grammar fixes and a rebase, otherwise feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #246 and #74.