Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Javadocs #137

Merged
merged 7 commits into from
Aug 22, 2018
Merged

Update Javadocs #137

merged 7 commits into from
Aug 22, 2018

Conversation

breedloj
Copy link
Contributor

Description

Updates Javadocs across the core module to be more descriptive and accurate. In many cases existing comments were not present, and in others they were out of date.

Motivation and Context

This is a long overdue overhaul to the Javadocs across the core module. Many snippets are pulled in from our ReadTheDocs pages.

Testing

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@nikhilym nikhilym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🚢 :shipit:

@breedloj breedloj merged commit 29c5300 into alexa:2.0.x Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants