Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CanFulfillIntentRequests #29

Closed
timothyaaron opened this issue Sep 14, 2018 · 8 comments · Fixed by #42
Closed

Allow CanFulfillIntentRequests #29

timothyaaron opened this issue Sep 14, 2018 · 8 comments · Fixed by #42
Labels

Comments

@timothyaaron
Copy link
Contributor

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Expected Behavior

CanFulfillIntentRequest request structures should be supported.

Current Behavior

If a request of type CanFulfillIntentRequest is received, it fails validation during Request deserialization.

Context

Notice I'm not asking for canFulfill "support" within the SDK (helper functions, etc), just allowing the request canFulfill structure to pass deserialization validation. Without it, it appears we'll have to resort to hacking the SDK itself.

@mhole44
Copy link

mhole44 commented Sep 14, 2018

I agree this would be a great feature. In the meantime, I've been using a workaround with Chalice. Set up your lambda handler to a pure lambda function (docs here). Then inside this pure lambda function you can use

try:
    sb.lambda_handler()(event, context)
except  SerializationException:
    # respond to CanFulfillIntentRequest

so that you can handle CanFulfillIntentRequests yourself.

@nikhilym
Copy link
Contributor

Hey @timothyaaron , thanks for the feature request. Will look into supporting the CanFulfillIntentRequest support.

@mhole44 , that's a nice little workaround. Thanks for posting around.

@nikhilym nikhilym added the feature-request:sdk SDK specific Feature Request label Sep 14, 2018
@timothyaaron
Copy link
Contributor Author

alexa/alexa-apis-for-python#2

If it's accepted, I'll follow it up with a PR to allow CanFulfillIntentRequest to use the is_intent_name helper.

@nikhilym
Copy link
Contributor

Hey @timothyaaron , thanks for the PR. Updated the PR

@timothyaaron
Copy link
Contributor Author

If anyone else is interested, I've forked and created a branch to handle CanFulfillIntentRequest. https://github.com/timothyaaron/alexa-apis-for-python/commits/can.fulfill

@nikhilym
Copy link
Contributor

nikhilym commented Nov 5, 2018

Hey @timothyaaron , @mhole44 , sorry that this feature took some time to come over to Python. But it is out now. Please update your models and SDK packages to the latest to get this over. Excited to see what the community builds using these.

PS: The feature is still under beta, so it might change during the GA release. So please take that into consideration.

@nikkopante
Copy link

Is it already released? by updating the SDK? Thanks!

@nikhilym
Copy link
Contributor

Hey @cnpants, yes, this feature has been released. Please update your SDK package to the latest version to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants