Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change get_slot_value function to return None when slot is not present #107

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Change get_slot_value function to return None when slot is not present #107

merged 1 commit into from
Jul 17, 2019

Conversation

Shreyas-vgr
Copy link
Contributor

Change get_slot_value function to return None when slot is not present

Description

Instead of throwing an error, it would be better to return null when the slot is not present in requestEnvelope. Thus developer don't need to check whether the slot is existed before calling this util function.

Motivation and Context

See above description

Testing

Changed the unit test and all unit tests passed.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@Shreyas-vgr Shreyas-vgr requested review from nikhilym and a team July 16, 2019 23:44
@Shreyas-vgr Shreyas-vgr merged commit 28a1a7b into alexa:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants